Disable interaction with disabled clickable components #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two more listeners being set up in the constructor. Should we move all the listeners being added to |
mister-ben
changed the title
|
Makes sense. I've also updated to make the component not selectable from the keyboard. |
|
@OwenEdwards can you take a look at this? LGTM, otherwise. |
| @@ -158,6 +164,13 @@ class ClickableComponent extends Component { | |||
| disable() { | |||
| this.addClass('vjs-disabled'); | |||
| this.el_.setAttribute('aria-disabled', 'true'); | |||
| if (typeof this.tabIndex_ !== 'undefined') { | |||
| this.el_.removeAttribute('tabindex'); | |||
There was a problem hiding this comment.
We had to enforce consistent use of tabIndex rather than tabindex throughout the code - it doesn't make any difference here, but it would be better for consistency.
Otherwise LGTM
|
LGTM |
misteroneill
added
confirmed
minor
gkatsev
approved these changes
Sep 27, 2016
gkatsev
approved these changes
Oct 3, 2016
There was a problem hiding this comment.
LGTM. Works great.
@mister-ben would you be able to rebase this against master? Otherwise, I can do it myself when merging.
mister-ben
force-pushed
the
disabled-clickable-components
branch
from
f12dbd3 to
12a41b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable()anddisable()on clickable components is only cosmetic. "Disabled" implies the control should not be functional.Specific Changes proposed
disable()and add back onenable().enabletabindexfrom disabled components and adddisabledattribute to disabled buttons to prevent keyboard access.Requirements Checklist