-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The guide should mention that your CDN version differs from your downloadable version and includes a third-party GA tracker #2286
Comments
We're working on it for 5.0. Thanks. |
Thanks. |
@heff What about http://videojs.com/getting-started/ ? |
@heff I believe it's past 5.0 already and your website still doesn't mention it. Could you reopen this issue, please? I don't believe it's fixed. |
It's mentioned explicitly in the setup documentation, which is what gets pulled into the docs website. |
It should clearly be present at http://videojs.com/getting-started/, as that's what suggests installing Video.js from CDN for newcomer users, and fails to mention that CDN version has GA. |
You need to tell people that video.js includes spyware upfront, on /getting-started. |
Yes, it should, particularly because the setup guide no longer mentions it (an oversight due to a semi-recent rewrite of it). I've opened a PR for that. |
I also opened a pull request that removes spyware entirely because why the fuck does this library have spyware in it |
Your attitude and behavior are totally unacceptable and immature. I'm locking this thread. |
See also #751 and #1848.
This guide, I mean: /docs/guides/setup.md
There are no mentions of Google Analytics in the sources either.
The text was updated successfully, but these errors were encountered: