Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The guide should mention that your CDN version differs from your downloadable version and includes a third-party GA tracker #2286

Closed
ChALkeR opened this issue Jun 25, 2015 · 10 comments

Comments

@ChALkeR
Copy link
Contributor

ChALkeR commented Jun 25, 2015

See also #751 and #1848.
This guide, I mean: /docs/guides/setup.md

There are no mentions of Google Analytics in the sources either.

@heff
Copy link
Member

heff commented Jun 29, 2015

We're working on it for 5.0. Thanks.
https://github.com/videojs/video.js/blob/master/docs/guides/setup.md

@heff heff closed this as completed Jun 29, 2015
@ChALkeR
Copy link
Contributor Author

ChALkeR commented Jun 29, 2015

Thanks.

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Dec 14, 2015

@heff What about http://videojs.com/getting-started/ ?

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Sep 5, 2016

@heff I believe it's past 5.0 already and your website still doesn't mention it.

Could you reopen this issue, please? I don't believe it's fixed.

@mmcc
Copy link
Member

mmcc commented Sep 5, 2016

It's mentioned explicitly in the setup documentation, which is what gets pulled into the docs website.

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Sep 6, 2016

It should clearly be present at http://videojs.com/getting-started/, as that's what suggests installing Video.js from CDN for newcomer users, and fails to mention that CDN version has GA.

@ddevault
Copy link

You need to tell people that video.js includes spyware upfront, on /getting-started.

@misteroneill
Copy link
Member

Yes, it should, particularly because the setup guide no longer mentions it (an oversight due to a semi-recent rewrite of it). I've opened a PR for that.

@ddevault
Copy link

I also opened a pull request that removes spyware entirely because why the fuck does this library have spyware in it

@misteroneill
Copy link
Member

Your attitude and behavior are totally unacceptable and immature. I'm locking this thread.

@videojs videojs locked and limited conversation to collaborators Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants