From 14c94561a96682c5827c16a38459fd347076a7dc Mon Sep 17 00:00:00 2001 From: Gary Katsevman Date: Wed, 18 Feb 2015 12:10:13 -0500 Subject: [PATCH] Only rely on selectedIndex to set select option. Firefox recently added selectedOptions support, however, unlike chrome and other browsers, they made it read-only and have it throw an error. In my testing (via http://jsfiddle.net/vwvdywf9/), on various browsers and platforms, just using selectedIndex was sufficient to change the selected option. closes #1877 --- CHANGELOG.md | 1 + src/js/tracks/text-track-settings.js | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e25791fe66..ef69e1ab17 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ CHANGELOG ## HEAD (Unreleased) * @gkatsev fixed the track list reference while switching techs that use emulated tracks ([view](https://github.com/videojs/video.js/pull/1874)) +* @gkatsev fixed a Firefox error with the captions settings select menu options ([view](https://github.com/videojs/video.js/pull/1877)) -------------------- diff --git a/src/js/tracks/text-track-settings.js b/src/js/tracks/text-track-settings.js index e0e949de19..32c5b99388 100644 --- a/src/js/tracks/text-track-settings.js +++ b/src/js/tracks/text-track-settings.js @@ -163,10 +163,6 @@ } } - if (target.selectedOptions) { - target.selectedOptions[0] = option; - } - target.selectedIndex = i; }