Skip to content

Commit 211cbe8

Browse files
authored
fix: clarify hls option deprecation warning (#1257)
Fixes #1256
1 parent 0964cb4 commit 211cbe8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/videojs-http-streaming.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ class VhsHandler extends Component {
508508
super(tech, videojs.mergeOptions(options.hls, options.vhs));
509509

510510
if (options.hls && Object.keys(options.hls).length) {
511-
videojs.log.warn('Using hls options is deprecated. Use vhs instead.');
511+
videojs.log.warn('Using hls options is deprecated. Please rename `hls` to `vhs` in your options object.');
512512
}
513513

514514
// if a tech level `initialBandwidth` option was passed

test/videojs-http-streaming.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ QUnit.test('logs deprecation notice when using hls for options', function(assert
416416
assert.equal(this.env.log.warn.calls, 1, 'warning logged');
417417
assert.equal(
418418
this.env.log.warn.args[0][0],
419-
'Using hls options is deprecated. Use vhs instead.'
419+
'Using hls options is deprecated. Please rename `hls` to `vhs` in your options object.'
420420
);
421421
});
422422

@@ -440,7 +440,7 @@ QUnit.test('logs deprecation notice when using hls for global options', function
440440
assert.equal(this.env.log.warn.calls, 1, 'warning logged');
441441
assert.equal(
442442
this.env.log.warn.args[0][0],
443-
'Using hls options is deprecated. Use vhs instead.'
443+
'Using hls options is deprecated. Please rename `hls` to `vhs` in your options object.'
444444
);
445445

446446
videojs.options.hls = origHlsOptions;

0 commit comments

Comments
 (0)