Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Support structured factors/essential factor interface #14

Closed
StannisZhou opened this issue Jul 14, 2021 · 1 comment · Fixed by #122
Closed

Support structured factors/essential factor interface #14

StannisZhou opened this issue Jul 14, 2021 · 1 comment · Fixed by #122
Assignees
@StannisZhou

Comments

@StannisZhou
Copy link
Contributor

No description provided.

@StannisZhou StannisZhou self-assigned this Jul 14, 2021
@StannisZhou StannisZhou added this to the 0.2 milestone Jul 27, 2021
@StannisZhou StannisZhou changed the title Outline plans to support structured factors/essential factor interface Support structured factors/essential factor interface Jul 27, 2021
@NishanthJKumar
Copy link
Contributor

As part of this, it's useful to define some general Factor class such that EnumerationFactor (and all other types of Factors that will be supported) are subclasses. Then, in graph.py, we can use Factor in all the typehints instead of having things specialized for EnumerationFactors as is currently the case.

@StannisZhou StannisZhou self-assigned this Oct 4, 2021
@StannisZhou StannisZhou linked a pull request Mar 14, 2022 that will close this issue
FactorGraph supports any type of factors + runs specialized inference for ORFactors #122
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StannisZhou StannisZhou

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@StannisZhou @NishanthJKumar