Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused argument : min.cov in toil-vg vcfeval #835

Open
zqfang opened this issue Jun 11, 2021 · 2 comments
Open

unused argument : min.cov in toil-vg vcfeval #835

zqfang opened this issue Jun 11, 2021 · 2 comments

Comments

@zqfang
Copy link

zqfang commented Jun 11, 2021

sveval_cmd += ', min.cov={}'.format(sv_overlap)

I've install the new sveval package from R.

BiocManager::install('jmonlong/sveval')

Change min.cov to min.ol could let the toil vdfeval work without issues

I don't know how this will affect the older version of toil-vg

@adamnovak
Copy link
Member

@glennhickey It looks like you wrote this part, but also it's @jmonlong's package

Can we just change this to min.ol? How long has the new sveval package been out?

I think we might end up installing sveval from the internet when we use it; I don't think we pin a version or package it in a container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants