Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all the setting of outputVar() to enforce the assignment of colNames explicitly. #4919

Closed
xtcyclist opened this issue Nov 23, 2022 · 1 comment
Closed

Refactor all the setting of outputVar() to enforce the assignment of colNames explicitly. #4919

xtcyclist opened this issue Nov 23, 2022 · 1 comment
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@xtcyclist
Copy link
Contributor

Refactor

void setOutputVar(const std::string& var);

to

void setOutputVar(const std::string& var, const std::vector<std::string>& colNames);

in order to reduce the risk of setting colNames mistakenly.
@xtcyclist xtcyclist added the type/enhancement Type: make the code neat or more efficient label Nov 23, 2022
@xtcyclist xtcyclist mentioned this issue Nov 23, 2022
Closed
11 tasks
@wey-gu wey-gu mentioned this issue Nov 26, 2022
Closed
@xtcyclist
Copy link
Contributor Author

Have refactored and checked all assignments. No more bugs found. Close this for now.

@wey-gu wey-gu mentioned this issue Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor setOutputVar() to enforce the assignment of colNames explicitly. xtcyclist/nebula
1 participant
@xtcyclist