Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement for metrics #4586

Open
HarrisChu opened this issue Aug 26, 2022 · 0 comments
Open

enhancement for metrics #4586

HarrisChu opened this issue Aug 26, 2022 · 0 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@HarrisChu
Copy link
Contributor

HarrisChu commented Aug 26, 2022

Issue 1

generally there are three type metrics:

  • latency
  • succeed count
  • error count

but not all of metrics with these three types.

e.g.

graphd

  • num_sort_executors no latency
  • num_aggregate_executors no latency
  • optimizer_latency_us no count
  • num_indexscan_executors no count
  • num_opened_sessions no latency
  • num_rpc_sent_to_metad no latency

storaged

  • commit_log_latency_us no count
  • num_send_snapshot no latency

Issue 2

more explicit metric name

graphd
num_queries_hit_memory_watermark
num_query_errors
num_query_errors_leader_changes

num_query_errors = num_query_errors_leader_changes + num_queries_hit_memory_watermark num_queries_hit_memory_watermark should be num_query_errors_hit_memory_watermark?

do we have any other kind error?

@HarrisChu HarrisChu added the type/enhancement Type: make the code neat or more efficient label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant