Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphSessionManager: session failed to be removed won't be reclaimed #3612

Closed
wey-gu opened this issue Dec 30, 2021 · 0 comments · Fixed by #3651
Closed

GraphSessionManager: session failed to be removed won't be reclaimed #3612

wey-gu opened this issue Dec 30, 2021 · 0 comments · Fixed by #3651
Assignees
Labels
type/bug Type: something is unexpected
Milestone

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Dec 30, 2021

As title, a session will be removed from activeSessions_ regardless of its removing attempt being responded normally or not, thus the reclaim will never take care of it.

The following quoted the related discussion initialized by @iiibui:

context: #3567

void GraphSessionManager::removeSession(SessionID id) {
auto iter = activeSessions_.find(id);
if (iter == activeSessions_.end()) {
return;
}
iter->second->markAllQueryKilled();
auto resp = metaClient_->removeSession(id).get();
if (!resp.ok()) {
// it will delete by reclaim
LOG(ERROR) << "Remove session `" << id << "' failed: " << resp.status();
}
activeSessions_.erase(iter);
}

It means meta client will retry in reclaimExpiredSessions? But it will have no chance because session has been removed from activeSessions_.
It means meta server will do reclaim? But I didn't find any “reclaim” related operations in metad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants