Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable retry on network error #352

Closed
wenhaocs opened this issue Sep 10, 2024 · 1 comment
Closed

Disable retry on network error #352

wenhaocs opened this issue Sep 10, 2024 · 1 comment
Assignees
@HarrisChu
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wenhaocs
Copy link

Customer environment has circuit breaker to throw 504 HTTP errors on request timeout. If the timeout is caused by overloaded nebula server, retry on this kind of network error will make the situation worse. Please add an option to allow users not retry on network error.

Related ticket: https://nebula-graph.atlassian.net/jira/servicedesk/projects/NGSR/queues/custom/1/NGSR-184
@wenhaocs wenhaocs added the type/enhancement Type: make the code neat or more efficient label Sep 10, 2024
@wenhaocs wenhaocs mentioned this issue Sep 11, 2024
Merged
@wenhaocs wenhaocs reopened this Sep 16, 2024
@wenhaocs
Copy link
Author

The session related retry should be kept. Only disable network retry.

@wenhaocs wenhaocs closed this as completed Oct 7, 2024
@wey-gu wey-gu mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarrisChu HarrisChu

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarrisChu @wenhaocs