Fixes Istio proxy sidecar initialization issue #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2024 11:23
roypaulin
approved these changes
Feb 13, 2024
|
There is a test that fails with |
Yes, seems like an issue with our docker account. We no longer have pull access to our private repository where we keep all the server images. I have a PR opened (#704) to use a different repository for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in istio 1.17, the istio proxy is now injected as the first container. This breaks some assumptions in the operator code. It assumes that any sidecar is injected at the end and the first two containers are the nma and server. This changes fixes that by referencing containers by their names rather than index. I removed all of the helpers based on index and instead get them by name.