Speed up revive prepass #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2023 14:20
During the revive prepass, the operator will compare the paths in the VerticaDB with the data in communal storage. If there is a discrepancy, the operator will patch the VerticaDB so that the local paths match what is expected. This is done instead of failing the revive. Once the StatefulSet is updated, it is then updated in the pod. Prior to this change, pods that were on the old revision would be deleted. However, this could be a slow process because it was possible for pods to come back with the old revision, depending on which pods had the newest revision. To avoid this, the StatefulSet is simply deleted in this change. This is a quicker process.
roypaulin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the revive prepass, the operator will compare the paths in the VerticaDB with the data in communal storage. If there is a discrepancy, the operator will patch the VerticaDB so that the local paths match what is expected. This is done instead of failing the revive.
Once the StatefulSet is updated, it is then updated in the pod. Prior to this change, pods that were on the old revision would be deleted. However, this could be a slow process because it was possible for pods to come back with the old revision, depending on which pods had the newest revision.
To avoid this, the StatefulSet is simply deleted in this change. This is a quicker process.
Closes #568