Expose the http port in the service object #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2022 16:29
This fixes a bug that was introduced earlier in this release when we did the podfacts refactor. We were failing to create the http conf dir in the installer reconciler if the http server is enabled. The plan is enable the http e2e tests, which would have caught this, when we use the 12.0.2 server release in the CI.
roypaulin
approved these changes
Nov 25, 2022
| @@ -27,7 +27,7 @@ data: | |||
| set -o errexit | |||
|
|
|||
| # Version can change only validate a portion of it | |||
| curl --insecure --fail --verbose --key /certs/tls.key --cert /certs/tls.crt https://v-http-custom-certs-main-0.v-http-custom-certs:8443/version | tee /tmp/curl.out | |||
| curl --insecure --fail --verbose --key /certs/tls.key --cert /certs/tls.crt https://v-http-custom-certs-main-0.v-http-custom-certs:8443/info/version | tee /tmp/curl.out | |||
There was a problem hiding this comment.
Why did you change the url.
There was a problem hiding this comment.
The server team changed around the API name. I was just updating the test to reflect this. I will eventually get this testsuite (e2e-http-server) into our CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http server is experimental at the moment and is hidden behind
spec.httpServerMode: EnabledThis exposes a new port (8443) in the service port for the http server that runs inside vertica server. This also removes the agent port in the service object, which was never used because we never ended up running the agent within the container.
I am also renaming the
spec.httpServerSecretfield in the VerticaDB tospec.httpServerTLSSecret. Since this feature is experimental, there should not be anyone using it, so no dependency on the field that I am renaming.