create db needs to choose a primary subcluster #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 28, 2022 21:18
Small timing window exists that cause us to check the service object routing before it was actually changed.
Two fixes here: - timing window in operator-metrics. The guage for pod readyiness might not yet be updated when we check, even though the pod is ready. Adding a retry method. - Saw failures in upgrade-vertica-ks-0. If we don't include all of the pods in the start_db command, we can get stuck. Then attempts after to get podfacts die because the vsql commands fail.
…etes into shard-node-ratio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a database, we pick a subcluster from the vdb that new nodes will be added to. We previously picked the very first subcluster, but if this is defined as a secondary, we end up creating it as a primary. This PR fixes that by selecting the first primary subcluster in the vdb.
This also will log an event when we detect the shard/node ratio is not optimal. It should be no higher than 3:1. This could be an important event now that we have integration with the autoscaler.