Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting --parallel does not automatically set --continue #10013

Closed
1 task done
jenseng opened this issue Feb 19, 2025 · 1 comment · Fixed by #10015
Closed
1 task done

Setting --parallel does not automatically set --continue #10013

jenseng opened this issue Feb 19, 2025 · 1 comment · Fixed by #10015
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@jenseng
Copy link

jenseng commented Feb 19, 2025

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/jenseng/turbo-parallel-continue-bug

Which canary version will you have in your reproduction?

[email protected]

Enviroment information

turbo 2.4.3-canary.3

CLI:
   Version: 2.4.3-canary.3
   Path to executable: path/to/turbo-parallel-continue-bug/node_modules/turbo-darwin-arm64/bin/turbo
   Daemon status: Running
   Package manager: npm

Platform:
   Architecture: aarch64
   Operating system: macos
   WSL: false
   Available memory (MB): 3239
   Available CPU cores: 12

Environment:
   CI: None
   Terminal (TERM): xterm-256color
   Terminal program (TERM_PROGRAM): iTerm.app
   Terminal program version (TERM_PROGRAM_VERSION): 3.5.11
   Shell (SHELL): /bin/zsh
   stdin: false

Expected behavior

Specifying the --parallel flag should automatically set --continue to true, as documented here.

Actual behavior

Specifying the --parallel flag causes turbo to run with the (default) --continue=false behavior. If any task fails, then no more tasks will be run.

In order to ensure all tasks run, you need to explicitly set --continue.

To Reproduce

  • Check out this repo
  • Run npm install
  • Run npx turbo run build --concurrency 2 --parallel
  • Note that only 2 of the 5 tasks run (all build scripts intentionally fail)

Additional context

If the current behavior is desirable, this could just be treated as a documentation issue instead of a bug. IMO though implicitly setting --continue when using --parallel is likely what people expect to happen.

@jenseng jenseng added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Feb 19, 2025
@anthonyshew anthonyshew linked a pull request Feb 20, 2025 that will close this issue
@anthonyshew
Copy link
Contributor

anthonyshew commented Feb 20, 2025

Thanks for the Issue, Jon! #10015 has the docs fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants