Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveScopedStyles include in API #379

Closed
pungggi opened this issue Jan 7, 2018 · 4 comments
Closed

resolveScopedStyles include in API #379

pungggi opened this issue Jan 7, 2018 · 4 comments

Comments

@pungggi
Copy link
Contributor

pungggi commented Jan 7, 2018

Hi @giuseppeg

what do you think about embed the resolveScopedStyles function from #273 in the library.
So users can import it when needed?

Like

import {resolveScopedStyles} from 'styled-jsx'

?

@giuseppeg
Copy link
Collaborator

@pungggi it is a few lines utility that can be implemented by the users. I don't think that it is necessary to include it in the library.

@ebramanti
Copy link

@giuseppeg I think this could be really useful to be added as a template tag function, something like thirdPartyCss.

@Vadorequest
Copy link

@giuseppeg I disagree, when you find online examples using resolveScopedStyles but have no idea where it came and relentlessly try to import it like import {resolveScopedStyles} from 'styled-jsx', but because there is no export at styled-jsx you end up thinking it's not correctly installed and reinstall all node packages, to finally figure out it's non-provided.

@giuseppeg
Copy link
Collaborator

giuseppeg commented Mar 12, 2018

In v3 we are adding the following syntax:

const { className, styles } = css.resolve`div { color: red }`

to do the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants