Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): expand peer @next/eslint-plugin-next version #74

Conversation

mwskwong
Copy link
Contributor

@mwskwong mwskwong commented Oct 27, 2023

Briefly tested by installing it with --legacy-peer-deps. Doesn't seem to have any big issues arisen.

@mwskwong
Copy link
Contributor Author

mwskwong commented Nov 2, 2023

@codybrouwers would you mind taking a look at whether this change is feasible?

@mrmckeb mrmckeb changed the title feat: relax peer @next/eslint-plugin-next version to allow v14 feat: expand peer @next/eslint-plugin-next version Nov 3, 2023
codybrouwers
codybrouwers previously approved these changes Nov 3, 2023
Copy link
Member

@codybrouwers codybrouwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mwskwong!

@codybrouwers codybrouwers force-pushed the feature/allow-next-eslint-plugin-next-v14 branch from 2e5660d to 44e1ad8 Compare November 3, 2023 00:58
@mrmckeb mrmckeb changed the title feat: expand peer @next/eslint-plugin-next version feat(eslint): expand peer @next/eslint-plugin-next version Nov 3, 2023
@codybrouwers codybrouwers merged commit b2b253e into vercel:canary Nov 3, 2023
@vercel-release-bot
Copy link
Collaborator

🎉 This PR is included in version 5.1.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrmckeb
Copy link
Contributor

mrmckeb commented Nov 3, 2023

Hi @mwskwong, if you can test the canary release and let us know if it solves your problem - we can then publish the release.

@mwskwong
Copy link
Contributor Author

mwskwong commented Nov 3, 2023

@mrmckeb Just used it on the DEV build of my website. So far so good.

@vercel-release-bot
Copy link
Collaborator

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants