-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple tsconfigs for different environments #60
Conversation
ae4fd69
to
839c14c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ethan-Arrowood! We'll need to update the root README too.
I'll ask a few people to review these and compare to what we have in our internal repos.
Hey @Ethan-Arrowood, I've run this by a few people and the feedback is that we should focus on the lib/target versions for TypeScript and Node.js. The other settings make assumptions about the build system, which can vary greatly between projects (even our own). Instead can make use of shared monorepo configs, as you pointed out that How would you feel about updating this PR to focus on Node versions instead? As an example: Probably 16/18/20 would be enough for us, as we probably don't want to support anything older nor anything non-LTS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
Alright, take a look! |
7568ea5
to
81eff4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, almost ready to go.
One question - is this a breaking change? I think it might be, as there's no longer a config at @vercel/style-guide/typescript
if you're using tooling that doesn't support "exports"
- CC @styfle for thoughts too.
f8d3326
to
2b23f5a
Compare
🎉 This PR is included in version 5.2.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Ethan-Arrowood @mrmckeb In https://github.com/vercel/style-guide/blob/canary/typescript/tsconfig.node20.json, according to the doc: https://www.typescriptlang.org/tsconfig#lib
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds more tsconfigs.
Why do
node20
andnode20-esm
use the samelib
andtarget
asnode18
?Closes #59