Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: eslint-plugin-eslint-comments has been replaced by @eslint-community/eslint-comments #115

Open
JoshuaKGoldberg opened this issue Dec 1, 2024 · 3 comments · May be fixed by #114 or #116
Open

Comments

@JoshuaKGoldberg
Copy link

https://github.com/mysticatea/eslint-plugin-eslint-comments has been out of maintenance for quite some time. https://github.com/eslint-community/eslint-plugin-eslint-comments is its replacement. But this style guide still uses the former. Would you accept a PR switching to the latter?

@JoshuaKGoldberg JoshuaKGoldberg changed the title Bug: eslint-plugin-eslint-comments has been replaced by @eslint-community/eslint- Bug: eslint-plugin-eslint-comments has been replaced by @eslint-community/eslint-comments Dec 1, 2024
@appano1
Copy link

appano1 commented Dec 2, 2024

I’ve switched the package in this PR (#114), and I hope it resolves the issue.

@appano1 appano1 linked a pull request Dec 2, 2024 that will close this issue
@JoshuaKGoldberg
Copy link
Author

JoshuaKGoldberg commented Dec 2, 2024

Exciting!

Do you have an estimate of when #114 will be merged? If it's not this year, could I propose making this change on the canary/main branch in the meantime?

@appano1
Copy link

appano1 commented Dec 13, 2024

I’m not entirely sure when #114 will be merged, but if your proposal could be merged sooner, it’s definitely worth submitting it in the meantime.
I hope #114 gets merged soon as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants