Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React from 37906d4d-20250127 to c492f975-20250128 #75434

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Upgrade React from 37906d4d-20250127 to c492f975-20250128 #75434

merged 7 commits into from
Feb 4, 2025

Conversation

vercel-release-bot
Copy link
Collaborator

@ijjk ijjk added CI approved Approve running CI for fork type: next labels Jan 29, 2025
@ijjk
Copy link
Member

ijjk commented Jan 29, 2025 •
edited
Loading

Failing test suites

Commit: aae2bd5

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/development/app-dir/error-overlay/async-client-component/async-client-component.test.ts (PPR)

  • app-dir - async-client-component > app router client component async module
Expand output

● app-dir - async-client-component › app router client component async module

No Redbox to open.

  23 |     const browser = await next.browser('/client')
  24 |
> 25 |     await openRedbox(browser)
     |     ^
  26 |
  27 |     const description = await getRedboxDescription(browser)
  28 |     const componentStack = await getStackFramesContent(browser)

  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)

Cause:
elementHandle.click: Element is not attached to the DOM
Call log:
  - attempting click action
  -   waiting for element to be visible, enabled and stable

  394 |   click() {
  395 |     return this.chain((el: ElementHandleExt) => {
> 396 |       return el.click().then(() => el)
      |                 ^
  397 |     })
  398 |   }
  399 |

  at click (lib/browsers/playwright.ts:396:17)
  at openRedbox (lib/next-test-utils.ts:913:7)
  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:395:17)
  at click (lib/next-test-utils.ts:913:63)
  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 29, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
buildDuration 18.7s 16.2s N/A
buildDurationCached 15.5s 13s N/A
nodeModulesSize 391 MB 392 MB ⚠️ +25.4 kB
nextStartRea..uration (ms) 431ms 428ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
5306-HASH.js gzip 54 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 519 B 520 B N/A
Overall change 538 B 538 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
app-page-exp...dev.js gzip 386 kB 386 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB N/A
app-page-tur..prod.js gzip 145 kB 145 kB N/A
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 373 kB 373 kB ✓
app-page.run..prod.js gzip 128 kB 128 kB ✓
app-route-ex...dev.js gzip 39.2 kB 39.2 kB N/A
app-route-ex..prod.js gzip 25.6 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.6 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.8 kB 40.8 kB N/A
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.2 kB 60.2 kB N/A
Overall change 800 kB 800 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-c492f975-20250128 Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +7.1 kB
index.pack gzip 74.9 kB 75.5 kB ⚠️ +599 B
Overall change 2.17 MB 2.18 MB ⚠️ +7.7 kB
Diff details
Diff for bccd1874-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: dd5337e

@eps1lon eps1lon enabled auto-merge (squash) January 29, 2025 19:38
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-c492f975-20250128 branch 2 times, most recently from 6024b14 to d400ad4 Compare February 3, 2025 08:37
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-c492f975-20250128 branch from d400ad4 to dd5337e Compare February 3, 2025 18:08
@ijjk ijjk added the tests label Feb 3, 2025
eps1lon
eps1lon reviewed Feb 3, 2025
View reviewed changes
test/development/app-dir/missing-required-html-tags/index.test.ts Outdated
Comment on lines 66 to 72
await openRedbox(browser)
// TODO: Should show "missing tags" error
expect(await getRedboxDescription(browser)).toMatchInlineSnapshot(`
"In HTML, <p> cannot be a child of <#document>.
This will cause a hydration error."
`)
expect(await getRedboxTotalErrorCount(browser)).toBe(1)
Copy link
Member

@eps1lon eps1lon Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have the "missing tags" warning on canary either. It just had a fatal error from which we didn't recover which is why the assertion original passed:

In HTML, <p> cannot be a child of <#document>.

HierarchyRequestError: Failed to execute 'appendChild' on 'Node': Only one element on document allowed.

NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node

Still an issue that we have this unhelpful error though.

@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-c492f975-20250128 branch from 69650c8 to aae2bd5 Compare February 3, 2025 22:46
@eps1lon eps1lon merged commit 879e279 into canary Feb 4, 2025
129 of 130 checks passed
@eps1lon eps1lon deleted the update/react/19.1.0-canary-c492f975-20250128 branch February 4, 2025 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels
CI approved Approve running CI for fork locked tests type: next type: react-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vercel-release-bot @ijjk @eps1lon