Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HMR heartbeat configurable #3917

Closed
majelbstoat opened this issue Feb 28, 2018 · 2 comments
Closed

Make HMR heartbeat configurable #3917

majelbstoat opened this issue Feb 28, 2018 · 2 comments

Comments

@majelbstoat
Copy link

majelbstoat commented Feb 28, 2018

When running NextJS inside a docker container that mounts a local volume, the server is typically slower to respond than on bare metal. In combination with Node 8, this often leads to INCOMPLETE_CHUNKED_ENCODING errors when hot module reloading.

This was fixed for bare metal setups in #2166, but the chosen heartbeat is often too short for a containerised instance.

Can we make heartbeat in server/hot-reloader.js configurable through next.config.js?

https://github.com/zeit/next.js/blob/canary/server/hot-reloader.js#L224

@timneutkens
Copy link
Member

As no one else has brought up or upvoted this issue I don't think we should change the default.

@majelbstoat
Copy link
Author

If anyone else is struggling with this, the problem went away when I started using http2 in dev.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants