-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with strong-globalize
#68
Comments
I'm not sure if this is the same issue, but we are natively using globalize in some of our code and get the following error when we run
|
@jbcpollak Yes, I'm getting similar errors |
The root cause of this seems to be that Webpack is detecting The fix would be to disable the AMD detection in Webpack entirely. I just have no idea how to do that yet... ! |
Tried the latest version, same error |
Seems indeed that it's still broken with 0.3.0 @guybedford
|
Unfortunately it seems like #58 won't actually solve this as the code that does the lookup for "cldr" is beyond the reach of static analysis (for now). Strong globalize should work if the "cldr" directory from "node_modules/strong-globalize/cldr" is just emitted in the build. One option here might be to even hard-code the "cldr" directory emission for the specific version ranges of strong-globalize. We could create a custom ".json" manifest file to track these kinds of custom emissions. I know it sounds daft, but it would provide a path. |
Actually it turns out directory emission can work... should have a PR up soon. |
@guybedford I'm still getting errors. I'm not sure whether its due to globalize
|
I'm still getting the error with latest version:
|
Note the loopback bug fixes in PR #122 still haven't been merged. |
Oh ok |
Looks like
|
Any update? |
I am still facing this with loopback |
I'm using Loopback to build my project. Loopback/Stroploop internally uses Globalize and cldr for globalization in strong-globalize. Looks like they use webpack while building.
And I'm getting the following error:
The text was updated successfully, but these errors were encountered: