Always consider empty files as 100% tested #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neonichu Can you add a test proving this works please? |
| @@ -102,7 +102,11 @@ def rate_lines_tested | |||
| end | |||
|
|
|||
| def percentage_lines_tested | |||
| rate_lines_tested * 100 | |||
| if num_lines_testable == 0 | |||
There was a problem hiding this comment.
As far as I know the line_rate should also be set to 1.0 under that condition.
There was a problem hiding this comment.
@neonichu should we make that change too, for corbetura?
There was a problem hiding this comment.
Not necessarily. The cobertura output generator checks it as well.
|
This looks good, but let's add some tests like @kylef said |
|
I have updated the two existing tests which had zero-length files in them. Should've done that initially 😞 |
marklarr
added a commit
that referenced
this pull request
Dec 12, 2014
Always consider empty files as 100% tested
marklarr
pushed a commit
that referenced
this pull request
Dec 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is better to avoid "false positive" untested classes.