Merge pull request #24 from vektor-inc/fix/custom-field-default-rule

[ Change version ] 0.4.2 [ Bug fix ] Fixed bug in conditional branchi…

Author: kurudrive

readme.txt

@@ -35,6 +35,9 @@ However, by nesting Dynamic If Blocks, various conditional branching can be hand
 
 == Changelog ==
 
+= 0.4.2 =
+* [ Bug fix ] Fixed bug in conditional branching based on custom field values
+
 = 0.4.1 =
 * Update descriptions
 

src/block.json

@@ -19,7 +19,7 @@
 		},
 		"customFieldRule": {
 			"type": "string",
-			"default": ""
+			"default": "valueExists"
 		},
 		"customFieldValue": {
 			"type": "string",

src/index.php

@@ -82,7 +82,7 @@ function vk_dynamic_if_block_render( $attributes, $content ) {
 
 		if ( get_the_ID() ) {
 			$get_value = get_post_meta( get_the_ID(), $attributes['customFieldName'], true );
-			if ( 'valueExists' === $attributes['customFieldRule'] ) {
+			if ( 'valueExists' === $attributes['customFieldRule'] || empty( $attributes['customFieldRule'] ) ) {
 				if ( $get_value || '0' === $get_value ) {
 					$display_by_custom_field = true;
 				} else {

tests/test-dynamic-if.php

@@ -593,6 +593,24 @@ public function test_vk_dynamic_if_block_render() {
 				'content'   => 'Custom Field value not match',
 				'expected'  => '',
 			),
+			array(
+				'name'      => 'Custom Field value not match',
+				'go_to'     => get_permalink( $test_posts['event_post_id'] ),
+				'attribute' => array(
+					'ifPageType'       => 'none',
+					'ifPostType'       => 'none',
+					'customFieldName'  => 'price',
+					'customFieldRule'  => null,
+					'customFieldValue' => '100',
+				),
+				'test_meta' => array(
+					'post_id'    => $test_posts['event_post_id'],
+					'meta_key'   => 'price',
+					'meta_value' => '100',
+				),
+				'content'   => 'customFieldRule not set',
+				'expected'  => 'customFieldRule not set',
+			),
 		);
 
 		foreach ( $tests as $test ) {

vk-dynamic-if-block.php

@@ -5,8 +5,8 @@
  * Description: A dynamic block displays its Inner Blocks based on specified conditions, such as whether the current page is the front page or a single post, the post type, or the value of a Custom Field.
  * Author: Vektor,Inc.
  * Author URI: https://vektor-inc.co.jp/en/
- * Version: 0.4.1
- * Stable tag: 0.4.1
+ * Version: 0.4.2
+ * Stable tag: 0.4.2
  * License: GPL-2.0-or-later
  * Text Domain: vk-dynamic-if-block
  *