Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift named remap functions out of the parser #3864

Closed
JeanMertz opened this issue Sep 14, 2020 · 0 comments · Fixed by #3927
Closed

Lift named remap functions out of the parser #3864

JeanMertz opened this issue Sep 14, 2020 · 0 comments · Fixed by #3927
Assignees
Labels
domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language transform: remap Anything `remap` transform related type: tech debt A code change that does not add user value.

Comments

@JeanMertz
Copy link
Contributor

Right now our parser explicitly lists the function names that are supported, this means each new function needs to be added to that list.

Ideally the parser knows how to parse a generic function signature, which we can then map to a Rust enum to match the specific function. This reduces boilerplate, and in general is a good practice to follow.

See:

@JeanMertz JeanMertz added type: tech debt A code change that does not add user value. domain: transforms Anything related to Vector's transform components labels Sep 14, 2020
@binarylogic binarylogic added the domain: vrl Anything related to the Vector Remap Language label Sep 14, 2020
@JeanMertz JeanMertz added this to the 2020-09-14 - The Grid milestone Sep 14, 2020
@JeanMertz JeanMertz self-assigned this Sep 14, 2020
@JeanMertz JeanMertz added the transform: remap Anything `remap` transform related label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language transform: remap Anything `remap` transform related type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants