Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky s3_waits_for_full_batch_or_timeout_before_sending #3104

Closed
ktff opened this issue Jul 19, 2020 · 4 comments
Closed

Flaky s3_waits_for_full_batch_or_timeout_before_sending #3104

ktff opened this issue Jul 19, 2020 · 4 comments
Labels
domain: tests Anything related to Vector's internal tests have: nice This feature is nice to have. It is low priority. sink: aws_s3 Anything `aws_s3` sink related type: task Generic non-code related tasks

Comments

@ktff
Copy link
Contributor

ktff commented Jul 19, 2020

Ref. #2978

Tests that aws_s3 sink batches events.

https://github.com/timberio/vector/pull/3099/checks?check_run_id=886641917
https://github.com/timberio/vector/runs/868843252

@ktff ktff added the domain: tests Anything related to Vector's internal tests label Jul 19, 2020
@ktff ktff added have: nice This feature is nice to have. It is low priority. sink: aws_s3 Anything `aws_s3` sink related type: task Generic non-code related tasks labels Jul 19, 2020
@binarylogic
Copy link
Contributor

Thanks @ktff, just so I understand, is there any reason the linked PR didn't close this?

@ktff
Copy link
Contributor Author

ktff commented Jul 19, 2020

@binarylogic Yes, the linked PR only removed the test, it yet needs to be fixed/rewritten.

Although it can also stay removed. This and #3043 are nice to have, but they aren't useful too much. In case of this test, the batch code is shared with other sinks so it overlaps with other tests.

@binarylogic
Copy link
Contributor

Got it. Let's leave them open so we can review in the future when we get around to tech debt again.

@jszwedko
Copy link
Member

jszwedko commented Aug 3, 2022

Closing since this test was deleted and evidently doesn't appear to have been needed.

@jszwedko jszwedko closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: tests Anything related to Vector's internal tests have: nice This feature is nice to have. It is low priority. sink: aws_s3 Anything `aws_s3` sink related type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

3 participants