Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test_max_size_resume #3039

Closed
ktff opened this issue Jul 12, 2020 · 2 comments
Closed

Flaky test_max_size_resume #3039

ktff opened this issue Jul 12, 2020 · 2 comments
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: tests Anything related to Vector's internal tests have: must We must have this feature, it is critical to the project's success. It is high priority. type: task Generic non-code related tasks type: tech debt A code change that does not add user value.

Comments

@ktff
Copy link
Contributor

ktff commented Jul 12, 2020 •
edited
Loading

Ref. #2978

Tests that we don't loose any events if internal buffers get full.

test_max_size_resume.log
https://github.com/timberio/vector/pull/3044/checks?check_run_id=862915559

Probably a race, but it may be a bug.
@ktff ktff added the domain: tests Anything related to Vector's internal tests label Jul 12, 2020
@ktff ktff mentioned this issue Jul 12, 2020
Merged
@binarylogic binarylogic added domain: buffers Anything related to Vector's memory/disk buffers type: task Generic non-code related tasks labels Jul 12, 2020
@ktff ktff added the have: must We must have this feature, it is critical to the project's success. It is high priority. label Jul 19, 2020
@ktff ktff mentioned this issue Aug 1, 2020
Merged
1 task
@ktff
Copy link
Contributor Author

ktff commented Aug 4, 2020

#3308 doesn't seem as the main cause.

@binarylogic binarylogic added the type: tech debt A code change that does not add user value. label Aug 6, 2020
@jamtur01 jamtur01 mentioned this issue Sep 12, 2020
Closed
@jszwedko
Copy link
Member

jszwedko commented Aug 3, 2022

Closing since this test was deleted and evidently doesn't appear to have been needed.

@jszwedko jszwedko closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: tests Anything related to Vector's internal tests have: must We must have this feature, it is critical to the project's success. It is high priority. type: task Generic non-code related tasks type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jszwedko @binarylogic @ktff