Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sources::journald::tests::filter_unit_works_correctly reliably broken. #3000

Closed
Hoverbear opened this issue Jul 9, 2020 · 3 comments · Fixed by #3005
Closed

Test sources::journald::tests::filter_unit_works_correctly reliably broken. #3000

Hoverbear opened this issue Jul 9, 2020 · 3 comments · Fixed by #3005
Assignees
@bruceg
Labels
source: journald Anything `journald` source related type: bug A code related bug.

Comments

@Hoverbear
Copy link
Contributor

Seems the test sources::journald::tests::filter_unit_works_correctly is broken.

https://github.com/timberio/vector/blob/349ad526c8e86b3b271ee7bb04134d15a2c1566f/src/sources/journald.rs#L725

hoverbear@OBSIDIAN:/git/timberio/vector$ RUST_LOG=vector=trace cargo test sources::journald::tests::filter_unit_works_correctly -- --nocapture
    Finished test [unoptimized + debuginfo] target(s) in 1.39s
     Running target/debug/deps/vector-faae61e99582f531

running 1 test
thread 'sources::journald::tests::filter_unit_works_correctly' panicked at 'assertion failed: `(left == right)`
  left: `false`,
 right: `true`', src/sources/journald.rs:725:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test sources::journald::tests::filter_unit_works_correctly ... FAILED

failures:

failures:
    sources::journald::tests::filter_unit_works_correctly

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 652 filtered out

Blocks #2961
@Hoverbear Hoverbear added type: bug A code related bug. source: journald Anything `journald` source related labels Jul 9, 2020
@Hoverbear
Copy link
Contributor Author

Might be #2959 ?

@bruceg bruceg self-assigned this Jul 9, 2020
@bruceg
Copy link
Member

bruceg commented Jul 9, 2020

Confirmed, I am investigating.

@bruceg bruceg mentioned this issue Jul 9, 2020
Merged
@fanatid
Copy link
Contributor

fanatid commented Jul 10, 2020

Sorry for new bug :(

@Hoverbear Hoverbear mentioned this issue Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruceg bruceg

Labels
source: journald Anything `journald` source related type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(journald source): Fix filter_unit_works_correctly test vectordotdev/vector
3 participants
@Hoverbear @bruceg @fanatid