Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd not reloaded after a package upgrade #2553

Closed
gtie opened this issue May 6, 2020 · 1 comment · Fixed by #3832
Closed

Systemd not reloaded after a package upgrade #2553

gtie opened this issue May 6, 2020 · 1 comment · Fixed by #3832
Assignees
Labels
domain: releasing Anything related to releasing Vector have: must We must have this feature, it is critical to the project's success. It is high priority. platform: debian Anything `debian` platform related platform: ubuntu Anything `ubuntu` platform related type: bug A code related bug.

Comments

@gtie
Copy link

gtie commented May 6, 2020

After upgrading to vector 0.9.1 using apt on a Debian system, I noticed the following warning in systemd after restarting the vector service:

# systemctl status vector
Warning: The unit file, source configuration file or drop-ins of vector.service changed on disk. Run 'systemctl daemon-reload' to reload units.
● vector.service - Vector
   Loaded: loaded (/etc/systemd/system/vector.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/vector.service.d
           └─override.conf
   Active: active (running) since Wed 2020-05-06 09:36:47 UTC; 12min ago

A bit of poking around showed that no content changed in the stock /etc/systemd/system/vector.service file or in my overrides. The only difference was the timestamp on vector.service file!

It is certainly easy to make that message go away, and run a manual daemon-reload, but it should not be necessary with a well-behaved .deb package. Running a daemon-reload should instead be done in a post-install script, and it is going to be even more important to do so when the service file does change in a future version.

@binarylogic binarylogic added domain: operations platform: debian Anything `debian` platform related platform: ubuntu Anything `ubuntu` platform related type: bug A code related bug. labels May 6, 2020
@binarylogic
Copy link
Contributor

Thanks @gtie, agree. I was not aware this was the behavior. We’ll prioritize get this fixed.

@binarylogic binarylogic self-assigned this May 6, 2020
@binarylogic binarylogic added domain: releasing Anything related to releasing Vector and removed domain: operations labels Jul 29, 2020
@binarylogic binarylogic removed their assignment Aug 7, 2020
@binarylogic binarylogic added the have: must We must have this feature, it is critical to the project's success. It is high priority. label Aug 7, 2020
@jamtur01 jamtur01 added type: bug A code related bug. and removed type: bug A code related bug. labels Sep 10, 2020
@jamtur01 jamtur01 self-assigned this Sep 11, 2020
@jamtur01 jamtur01 added this to the 2020-09-14 - The Grid milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: releasing Anything related to releasing Vector have: must We must have this feature, it is critical to the project's success. It is high priority. platform: debian Anything `debian` platform related platform: ubuntu Anything `ubuntu` platform related type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants