Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): populated the new github 'type' field for features #22315

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 28, 2025

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from a team as a code owner January 28, 2025 17:27
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 28, 2025
@pront pront requested a review from bfung January 28, 2025 17:28
@pront pront enabled auto-merge January 28, 2025 17:28
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 28, 2025

Datadog Report

Branch report: pront/github-type-feat
Commit report: c5259a2
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

@jszwedko
Copy link
Member

This could probably replace the existing type: * labels we have too 🤔

@pront
Copy link
Member Author

pront commented Jan 28, 2025

This could probably replace the existing type: * labels we have too 🤔

Yes, didn't want to jump the gun on this just yet but we can add a type and remove the type label for all issues. I can automate this with the Github API.

@pront pront added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 1af287f Jan 28, 2025
57 checks passed
@pront pront deleted the pront/github-type-feat branch January 28, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants