Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.concurrency default is incorrectly documented #18593

Closed
jszwedko opened this issue Sep 18, 2023 · 0 comments
Closed

request.concurrency default is incorrectly documented #18593

jszwedko opened this issue Sep 18, 2023 · 0 comments
Labels
domain: ARC Anything related to adaptive request concurrency domain: config Anything related to configuring Vector domain: external docs Anything related to Vector's external, public documentation type: bug A code related bug.

Comments

@jszwedko
Copy link
Member

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

The website documents the default of request.concurrency as none and says that this indicates "no concurrency" (the same as setting it to 1. However, the actual meaning of "none" here is "adaptive". We should update the docs.

Example: https://vector.dev/docs/reference/configuration/sinks/http/#request.concurrency

Configuration

No response

Version

vector v0.32.1

Debug Output

No response

Example Data

No response

Additional Context

No response

References

@jszwedko jszwedko added type: bug A code related bug. domain: config Anything related to configuring Vector domain: ARC Anything related to adaptive request concurrency labels Sep 18, 2023
@jszwedko jszwedko added the domain: external docs Anything related to Vector's external, public documentation label Sep 18, 2023
@StephenWakely StephenWakely self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ARC Anything related to adaptive request concurrency domain: config Anything related to configuring Vector domain: external docs Anything related to Vector's external, public documentation type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

3 participants