Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom integration runner in vdev with compose #17051

Open
Tracked by #16381
bruceg opened this issue Apr 4, 2023 · 0 comments
Open
Tracked by #16381

Replace custom integration runner in vdev with compose #17051

bruceg opened this issue Apr 4, 2023 · 0 comments
Assignees
Labels
domain: vdev Anything related to the vdev tooling type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Apr 4, 2023

The original integration test setup had a runner block in every docker compose file with nearly identical contents. The reworked setup used by vdev removed that duplication and moved it into the tool by setting up a custom runner outside of docker compose. Unfortunately, this has created considerable complication within vdev for managing that setup external to the main docker-compose containers.

With #17025, we will have a framework for injecting bits into the compose files before they containers are built. We should use this capability to set up a standardized runner block and run the entire network of containers within docker-compose. This will simplify running integration tests in vdev and allow us to remove all the code specialized on handling the test runner separately.

@bruceg bruceg added type: tech debt A code change that does not add user value. domain: vdev Anything related to the vdev tooling labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vdev Anything related to the vdev tooling type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

2 participants