Skip to content

Commit 93ad80d

Browse files
authored
fix(codecs) csv encoding quoting bug (#18320)
* added additional csv configuration options found potential bug on writing lines with quoted fields * implemented suggestions of pront * added configurable QuotingStyle and made problematic quoted tests pass for now * switched to defaults by serde * refactor csv codec to use low level csv-core to fix missing closing quote bug * fixed typo * use field iterator to count written filds instead of manual counter * moved internal_buffer into CsvSerializer to not recreated with every call to encode() * improoved comments * implemented suggestions * cleanup * refactored test * low level csv writer api refactor * Revert "low level csv writer api refactor" This reverts commit c730d58. * some more cleanup * generate-component-docs
1 parent e39d9b3 commit 93ad80d

29 files changed

+2340
-283
lines changed

Cargo.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/codecs/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ publish = false
99
apache-avro = { version = "0.15.0", default-features = false }
1010
bytes = { version = "1", default-features = false }
1111
chrono = { version = "0.4", default-features = false }
12-
csv = { version = "1.2", default-features = false }
12+
csv-core = { version = "0.1.10", default-features = false }
1313
derivative = { version = "2", default-features = false }
1414
dyn-clone = { version = "1", default-features = false }
1515
lookup = { package = "vector-lookup", path = "../vector-lookup", default-features = false }

0 commit comments

Comments
 (0)