Install apk from the app - REQUEST_INSTALL_PACKAGES

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

The app is requesting REQUEST_INSTALL_PACKAGES permission, but some code was missing to handle this properly.

Also when the mime type is not know, try to guess it from the file extension.

I have also provided the link to the demo video (https://github.com/vector-im/element-x-android/assets/3940906/19d47d51-998a-4d82-a8a8-44a0f38317fe) to the PlayStore form.

First commit is a small cleanup.

Motivation and context

Fix rejection from PlayStore.

Screenshots / GIFs

Before	After

Tests

• Send an APK to a timeline and try to open it from the app.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qrtPvF

[codecov]

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (d8fbf21) 58.06% compared to head (0d00e8d) 58.02%.
Report is 7 commits behind head on develop.

❗ Current head 0d00e8d differs from pull request most recent head 3eb1123. Consider uploading reports for the commit 3eb1123 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1432      +/-   ##
===========================================
- Coverage    58.06%   58.02%   -0.05%     
===========================================
  Files         1129     1129              
  Lines        29880    29913      +33     
  Branches      6067     6079      +12     
===========================================
+ Hits         17351    17358       +7     
- Misses        9931     9955      +24     
- Partials      2598     2600       +2     

Files	Coverage Δ
...ent/android/features/location/api/StaticMapView.kt	50.98% <100.00%> (ø)
...n/impl/screens/waitlistscreen/WaitListPresenter.kt	88.23% <100.00%> (ø)
...messages/impl/media/viewer/MediaViewerPresenter.kt	87.80% <100.00%> (ø)
...res/rageshake/impl/bugreport/BugReportPresenter.kt	91.17% <100.00%> (ø)
...raries/designsystem/swipe/SwipeableActionsState.kt	26.31% <100.00%> (ø)
.../libraries/designsystem/theme/components/Slider.kt	51.85% <100.00%> (ø)
...ibraries/matrix/ui/components/SelectedUsersList.kt	71.42% <100.00%> (ø)
...oid/libraries/matrix/impl/media/RustMediaLoader.kt	0.00% <0.00%> (ø)
...ures/messages/impl/media/viewer/MediaViewerView.kt	65.81% <66.66%> (+0.39%)	⬆️
...ement/android/libraries/core/mimetype/MimeTypes.kt	0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Just one remark otherwise LGTM

[ganfra]

Please clean this part?

[bmarty]

I did not change this, it was at line 106 in the previous version of the file. But I will add a commit to fix another potential issue.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[ElementBot]

• ⚠️ Very long vector path (1005 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.