Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v5 of AntD #1261

Closed
radekmie opened this issue May 4, 2023 · 3 comments · Fixed by #1376
Closed

Support v5 of AntD #1261

radekmie opened this issue May 4, 2023 · 3 comments · Fixed by #1376
Labels
Area: Theme Affects some of the theme packages Help Wanted Orphaned and discontinued issues that need your help Theme: AntD Affects the uniforms-antd package Type: Feature New features and feature requests
Milestone
v4.x

Comments

@radekmie
Copy link
Contributor

radekmie commented May 4, 2023

Firstly check, whether it's possible to support both v4 and v5 with the same code. If so, do that. If not, we'd need to create a new theme, just like with Bootstrap.
@radekmie radekmie added Type: Feature New features and feature requests Help Wanted Orphaned and discontinued issues that need your help Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package labels May 4, 2023
@radekmie radekmie added this to the v4.x milestone May 4, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Open Source May 4, 2023
@radekmie radekmie mentioned this issue May 4, 2023
Closed
@fschmutz
Copy link

fschmutz commented Dec 1, 2023

Hello, any idea when it will be ok ? :)

@Monteth
Copy link
Member

Monteth commented Mar 22, 2024

AntD v5 seems to be significantly incompatible with v4, so we'd need to create a new theme for it. AntD v4 is quite a popular theme for uniforms, and AntD v5 itself seems to be widely adopted, so it would be nice to officially support it. We need to consider implementing it after releasing uniforms v4.

@fschmutz
Copy link

Great work on uniforms!
Many of us maybe are eagerly waiting for the update to make it compatible with v5 to move along with React 18 advancements.
We appreciate the hard work involved and are keen to support in any way we can to help make this transition happen. Looking forward to the update and how we can contribute!

@bmartin1134 bmartin1134 mentioned this issue Oct 22, 2024
Closed
@piotrpospiech piotrpospiech mentioned this issue Oct 28, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Open Source Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Theme Affects some of the theme packages Help Wanted Orphaned and discontinued issues that need your help Theme: AntD Affects the uniforms-antd package Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Milestone
v4.x
Development

Successfully merging a pull request may close this issue.

Update React to v18 & AntD to v5 vazco/uniforms
3 participants
@radekmie @fschmutz @Monteth