Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Netbox 4.2 #8280

Open
jmcguir opened this issue Jan 28, 2025 · 0 comments · May be fixed by #8417
Open

Compatibility with Netbox 4.2 #8280

jmcguir opened this issue Jan 28, 2025 · 0 comments · May be fixed by #8417
Assignees
@pdonias
Labels
status::triaging 🚩

Comments

@jmcguir
Copy link

jmcguir commented Jan 28, 2025 •
edited by julien-f
Loading

Due to the scope changes on clusters the netbox plugin won't work with 4.2

https://netboxlabs.com/docs/netbox/en/stable/release-notes/version-4.2/

These two sections will need an upgrade to support 4.2:

  1. https://github.com/vatesfr/xen-orchestra/blob/3e69d4c84b2e18c00aebf5362fa7baa16cd30043/packages/xo-server-netbox/src/index.js#L495C1-L495C77

  2. xen-orchestra/packages/xo-server-netbox/src/index.js

    Line 566 in 3e69d4c

    site: nbVm.site == null ? nbVm.site : nbVm.site.id,

this is what site looks like now on a cluster:

 "scope_type": "dcim.site",
    "scope_id": 5121,
    "scope": {
        "id": 5121,
        "url": "https://netbox.localhost.net/api/dcim/sites/5121/",
        "display": "6464",
        "name": "6464",
        "slug": "site_6464",
        "description": "Paris"
    },
pdonias added a commit that referenced this issue Mar 7, 2025
@pdonias
feat(netbox): support Netbox v4.2
bd0bb0d 
Fixes #8280
See Zammad#34699
See https://xcp-ng.org/forum/topic/10236/netbox-version-4-2-1-not-supported
See https://github.com/netbox-community/netbox/releases/tag/v4.2.0

Nothing to do because:
- Clusters: `site` is replaced by `scope` (a region, site, site group or
  location) but we don't auto-assign `site` on clusters.
- VMs: `site` field still exists. We don't assign it except for old versions
  where we use the cluster's `site`.
- Prefixes: `site` is also replaced by `scope` but prefixes are created
  manually.
@pdonias pdonias linked a pull request Mar 7, 2025 that will close this issue
Open
pdonias added a commit that referenced this issue Mar 7, 2025
@pdonias
feat(netbox): support Netbox v4.2
08d5c82 
Fixes #8280
Fixes #7645
See Zammad#34699
See https://xcp-ng.org/forum/topic/10236/netbox-version-4-2-1-not-supported
See https://github.com/netbox-community/netbox/releases/tag/v4.2.0

Nothing to do because:
- Clusters: `site` is replaced by `scope` (a region, site, site group or
  location) but we don't auto-assign `site` on clusters.
- VMs: `site` field still exists. We don't assign it except for old versions
  where we use the cluster's `site`.
- Prefixes: `site` is also replaced by `scope` but prefixes are created
  manually.
pdonias added a commit that referenced this issue Mar 10, 2025
@pdonias
feat(netbox): support Netbox v4.2
5447046 
Fixes #8280
Fixes #7645
See Zammad#34699
See https://xcp-ng.org/forum/topic/10236/netbox-version-4-2-1-not-supported
See https://github.com/netbox-community/netbox/releases/tag/v4.2.0

Nothing to do because:
- Clusters: `site` is replaced by `scope` (a region, site, site group or
  location) but we don't auto-assign `site` on clusters.
- VMs: `site` field still exists. We don't assign it except for old versions
  where we use the cluster's `site`.
- Prefixes: `site` is also replaced by `scope` but prefixes are created
  manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdonias pdonias

Labels
status::triaging 🚩
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(netbox): support Netbox v4.2 vatesfr/xen-orchestra
3 participants
@julien-f @pdonias @jmcguir