Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-vendor the swift-collections implementation #82

Closed
gwynne opened this issue Apr 26, 2022 · 5 comments · Fixed by #83
Closed

Un-vendor the swift-collections implementation #82

gwynne opened this issue Apr 26, 2022 · 5 comments · Fixed by #83
Assignees
@ahmdyasser
Labels
good first issue Good for newcomers help wanted Extra attention is needed semver-patch Internal changes only

Comments

@gwynne
Copy link
Member

gwynne commented Apr 26, 2022

multipart-kit currently contains a somewhat outdated version of OrderedSet and OrderedDictionary taken from the then-current pre-release version of swift-collections; this vendored implementation should be replaced with a dependency on swift-collections 1.x.

cc @siemensikkema
@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels Apr 26, 2022
@0xTim 0xTim added help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Apr 26, 2022
@ahmdyasser
Copy link
Member

ahmdyasser commented Apr 29, 2022 •
edited
Loading

Should this PR include deleting the current OrderedSet and OrderedDictionary implementation files?

@gwynne
Copy link
Member Author

gwynne commented Apr 29, 2022

That's the intention, yes.

@ahmdyasser
Copy link
Member

That's the intention, yes.

done! checkout my PR

@ahmdyasser
Copy link
Member

Hi @gwynne! I cannot assign myself to any of the issues in the board. I think I first need to be a member? is it possible to add me to "members"?
image

@0xTim
Copy link
Member

0xTim commented May 3, 2022

Assigned to you for now. I'll see what the best way to enable assigning for outside contributors will be as this won't be the first time we hit this and want to encourage new contributors

@0xTim 0xTim mentioned this issue May 15, 2022
Merged
@0xTim 0xTim closed this as completed in #83 May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmdyasser ahmdyasser

Labels
good first issue Good for newcomers help wanted Extra attention is needed semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on Swift Collections ahmdyasser/multipart-kit
3 participants
@gwynne @0xTim @ahmdyasser