Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): add animation to the component #5475

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Oct 11, 2019

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

daniloff200
daniloff200 previously approved these changes Oct 11, 2019
Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj !

daniloff200
daniloff200 previously approved these changes Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #5475 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5475   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2676683...f24d36d. Read the comment docs.

@Domainv Domainv force-pushed the feat-dropdown-add-animation branch from 98e7b23 to f24d36d Compare October 11, 2019 13:55
@Domainv Domainv merged commit d70f08b into development Oct 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-dropdown-add-animation branch October 11, 2019 13:56
@Domainv Domainv added this to the 5.3.0 milestone Oct 11, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants