Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Python test test_update_connection_password() fails (flaky?) #3058

Closed
ikolomi opened this issue Feb 4, 2025 · 0 comments
Closed

CI: Python test test_update_connection_password() fails (flaky?) #3058

ikolomi opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels
bug Something isn't working CI/CD CI/CD related Flaky-tests Flaky-tests python Python wrapper testing Everything about testing

Comments

@ikolomi
Copy link
Collaborator

ikolomi commented Feb 4, 2025

Describe the bug

test_update_connection_password() failed with:


java.util.concurrent.ExecutionException: glide.api.models.exceptions.RequestException: request wasn't handled due to internal failure- ResponseError

as seen in the full matrix run: https://github.com/valkey-io/valkey-glide/actions/runs/13127527442/job/36638505186

In general, tests that setup password and kill the connection are subjected to timing interplay between the reconnect mechanism and the retrying of the following command as explained here: #3022

Maybe introducing a small delay between the KILL and update_connection_password() is required as done in a few lines above:

        await kill_connections(management_client)
        # Add a short delay to allow the server to apply the new password
        # without this delay, command may or may not time out while the client reconnect
        # ending up with a flaky test
        await asyncio.sleep(1)
        # Verify that the client is able to reconnect with the new password,
        value = await glide_client.get("test_key")

Consult with @Yury-Fridlyand as there is a same issue in Java: #3057
We need a cross binding solution

Expected Behavior

test always passes

Current Behavior

test is flaky

Reproduction Steps

.

Possible Solution

Introduce a delay?

Additional Information/Context

No response

Client version used

.

Engine type and version

.

OS

.

Language

Python

Language Version

.

Cluster information

No response

Logs

No response

Other information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD CI/CD related Flaky-tests Flaky-tests python Python wrapper testing Everything about testing
Projects
Status: Done
Development

No branches or pull requests

3 participants