Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split test/validators.js file to separate sub files #1791

Open
Marcholio opened this issue Oct 14, 2021 · 3 comments
Open

Split test/validators.js file to separate sub files #1791

Marcholio opened this issue Oct 14, 2021 · 3 comments
Labels
🍿 discussion 🙋‍♂️feature-request maintenance pr-raised

Comments

@Marcholio
Copy link
Contributor

Hi, the main test file for validator.js is currently 11k+ lines long. What do you think, could/should it be split to multiple sub files by validator for example?

So the end result could be something like:

/test
  validators.js
  /validators
    isLicensePlate.js
    isVat.js
    etc...

Would that improve the readibility of the test cases?
@tux-tn
Copy link
Member

tux-tn commented Oct 14, 2021

Thank you for your suggestion @Marcholio ! I totally agree with the idea

@Marcholio Marcholio mentioned this issue Oct 15, 2021
Closed
3 tasks
@Marcholio
Copy link
Contributor Author

Created a PR addressing this @tux-tn

@tux-tn
Copy link
Member

tux-tn commented Oct 16, 2021

@Marcholio great job ! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍿 discussion 🙋‍♂️feature-request maintenance pr-raised
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring: Splitted test/validators.js to multiple subfiles Marcholio/validator.js
2 participants
@tux-tn @Marcholio