Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute: Support for more locales to isTaxID #1423

Closed
tplessas opened this issue Aug 26, 2020 · 6 comments · Fixed by #1446
Closed

Contribute: Support for more locales to isTaxID #1423

tplessas opened this issue Aug 26, 2020 · 6 comments · Fixed by #1446

Comments

@tplessas
Copy link
Contributor

Hello everyone,

I would like to add support for EU member state & UK tax identification numbers to isTaxID based on this document: https://ec.europa.eu/taxation_customs/tin/specs/FS-TIN%20Algorithms-Public.docx

I see that PR #1409 has already paved the way, so I could fork and work from there once it's merged. Please let me know if that would be welcome!

@tplessas
Copy link
Contributor Author

tplessas commented Sep 15, 2020

Still very much interested in contributing to the project. I have implemented support for many new TINs here, all ready to be pulled once I update the readme: https://github.com/tplessas/validator.js/tree/refactor-isTaxID

As part of that I have also added (or will be adding) implementations of the ISO 7064, Luhn and Verhoeff validation algorithms, which could be spun off as separate validators for any kind of compatible number (IMEI, SIM, credit card, various social security and ID numbers).

@tplessas
Copy link
Contributor Author

...any news on interest? I have added all countries from the document, added tests and updated the readme.

@profnandaa
Copy link
Member

@tplessas -- oh, sure, this is very much welcome. Let me fast-track closing on #1409 -- you can help with any clean-ups needed there in case the author is a bit held up?

@tplessas
Copy link
Contributor Author

@profnandaa Of course, keeping an eye on it.

@profnandaa
Copy link
Member

@tplessas -- over to you now 👍 #1409 merged.

@firlus
Copy link
Contributor

firlus commented Oct 18, 2020

Included german version.

#1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants