Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-root workspaces #7

Closed
valentjn opened this issue Sep 8, 2019 · 1 comment
Closed

Support multi-root workspaces #7

valentjn opened this issue Sep 8, 2019 · 1 comment
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch

Comments

@valentjn
Copy link
Owner

valentjn commented Sep 8, 2019

Window-wide settings are not supported for the new multi-root workspaces. Some work has to be done to support these. They can also be nested.

Resources:

@valentjn valentjn added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Sep 8, 2019
@valentjn valentjn self-assigned this Sep 30, 2019
@valentjn
Copy link
Owner Author

valentjn commented Oct 1, 2019

LTEX now supports this in version 4.7.0. But the implementation was more complicated than expected...

For every LT check, we need to have the current configuration (language, dictionary, ...) for the file to be checked. This configuration can differ from workspace folder to workspace folder. However, I'm not sure when LSP clients notify the language server that the configuration has been changed (global configuration, workspace configuration, or workspace folder configuration?). The LSP spec doesn't say anything about that. So now we actively request the configuration from the client at the beginning of every LT check.

In addition, a single language server now has to check documents of different languages, for instance, we could have an English and a German workspace folder. So now we cache LanguageTool instances for the different languages, which (further) increases memory usage, but keeps checking time short. Also, I don't know when exactly a new instance of the server gets spawned. It doesn't seem to be once per VS Code window...

Please open new issues if there are any problems with the implementation (which is likely, given the amount of uncertainty I have).

@valentjn valentjn closed this as completed Oct 1, 2019
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

1 participant