Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix German plural of Dummy #178

Closed
wants to merge 2 commits into from
Closed

Fix German plural of Dummy #178

wants to merge 2 commits into from

Conversation

sfo
Copy link
Contributor

@sfo sfo commented Jul 27, 2022

In German, the plural form of Dummy is Dummys, not Dummies, which instead triggers a false positive:

ltex_dummies

@sfo
Fix German plural of Dummy
7c54b82 
In German, the plural form of Dummy is Dummys, not Dummies, which triggers a false positive.
@valentjn
Copy link
Owner

de is not the only German language in LanguageTool. At least de-DE (which should be preferred over de) is missing, plus all other variants of German for which this is applicable.

valentjn
valentjn requested changes Jul 27, 2022
View reviewed changes
Copy link
Owner

@valentjn valentjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Looks good otherwise.

@sfo
Copy link
Contributor Author

sfo commented Aug 1, 2022

Thanks for reviewing @valentjn. I adapted the patch accordingly.

@sfo sfo requested a review from valentjn August 25, 2022 07:45
valentjn added a commit that referenced this pull request Feb 12, 2023
@valentjn
Add test for plural dummy in German
85fd1f2 
Closes #178.
@valentjn valentjn self-assigned this Feb 12, 2023
@valentjn valentjn added this to the 16.0.0 milestone Feb 12, 2023
@valentjn
Copy link
Owner

valentjn commented Feb 12, 2023 •
edited
Loading

Fixed in b68af97, 190e8ae, 32926d4, and 85fd1f2.

@valentjn valentjn closed this Feb 12, 2023
@ainar ainar mentioned this pull request Mar 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentjn valentjn Awaiting requested review from valentjn

Assignees

@valentjn valentjn

Labels
None yet
Projects
None yet
Milestone
16.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sfo @valentjn