microsoft#2488 - Add using statement for EnumMember attribute

vadrsa · Mar 31, 2023 · 0f1c532 · 0f1c532
1 parent 9a09218
commit 0f1c532
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Kiota.Builder/Writers/CSharp/CodeEnumWriter.cs b/src/Kiota.Builder/Writers/CSharp/CodeEnumWriter.cs
@@ -14,6 +14,8 @@ public override void WriteCodeElement(CodeEnum codeElement, LanguageWriter write
         ArgumentNullException.ThrowIfNull(writer);
         if (!codeElement.Options.Any())
             return;
+        if (codeElement.Options.Any(x => x.IsNameEscaped))
+            writer.WriteLine($"using System.Runtime.Serialization;");
 
         var codeNamespace = codeElement.Parent as CodeNamespace;
         if (codeNamespace != null)
@@ -32,7 +34,7 @@ public override void WriteCodeElement(CodeEnum codeElement, LanguageWriter write
             {
                 writer.WriteLine($"[EnumMember(Value = \"{option.SerializationName}\")]");
             }
-            writer.WriteLine($"{option.Name.ToFirstCharacterUpperCase()}{(codeElement.Flags ? " = " + GetEnumFlag(idx) : string.Empty)},");
+            writer.WriteLine($"{option.Name}{(codeElement.Flags ? " = " + GetEnumFlag(idx) : string.Empty)},");
             idx++;
         }
         if (codeNamespace != null)

diff --git a/tests/Kiota.Builder.Tests/Writers/CSharp/CodeEnumWriterTests.cs b/tests/Kiota.Builder.Tests/Writers/CSharp/CodeEnumWriterTests.cs
@@ -55,6 +55,7 @@ public void NamesDiffer_WritesEnumMember()
         currentEnum.AddOption(new CodeEnumOption { Name = "InvalidName", SerializationName = "Invalid:Name"});
         writer.Write(currentEnum);
         var result = tw.ToString();
+        Assert.Contains($"using System.Runtime.Serialization;", result);
         Assert.Contains($"[EnumMember(Value = \"Invalid:Name\")]", result);
     }
 
@@ -66,6 +67,7 @@ public void NamesDontDiffer_DoesntWriteEnumMember()
         currentEnum.AddOption(new CodeEnumOption { Name = "ValidName"});
         writer.Write(currentEnum);
         var result = tw.ToString();
+        Assert.DoesNotContain($"using System.Runtime.Serialization;", result);
         Assert.DoesNotContain($"\"ValidName\"", result);
     }