vaadin-radio-button can be slected/checked accidentally

[RoProg]

Tested on windows and android (touch) devices using this demo site:
https://vaadin.com/components/vaadin-radio-button/html-examples

Reproduction:

1. Click on a not selected/checked radio-button and move the mouse cursor to some empty space while holding the mouse button.
2. Release the mouse button.
3. The radio-button will be selected.

It is also reproducible on touch screens.

This behavior leads to unwanted radio-button selections while scrolling or swiping on mobile devices.

[vlukashov]

Example on a touch screen (mobile):
https://user-images.githubusercontent.com/22416150/118711558-65bcb280-b828-11eb-9555-b1a1ba9cb5c1.mp4

Note that scrolling changes the selection, which is an unexpected UX. Native radio buttons do not do that.

[RoProg]

I fixed it for my project temporarily by replacing the following code (in vaadin-radio-button.js)

this._addEventListenerToNode(this, 'up', (e) => {
  this.removeAttribute('active'); 

  if (!this.checked && !this.disabled) {
     // If you change this block, please test manually that radio-button and
    // radio-group still works ok on iOS 12/13 and up as it may cause
    // an issue that is not possible to test programmatically.
    // See: https://github.com/vaadin/vaadin-radio-button/issues/140
    this.click();
  }
});

with

let isIOS = (/iPad|iPhone|iPod/.test(navigator.platform) ||
(navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1)) &&
!window.MSStream;

this._addEventListenerToNode(this, 'up', (e) => {
  this.removeAttribute('active');

  if (!this.checked && !this.disabled) {
    // If you change this block, please test manually that radio-button and
    // radio-group still works ok on iOS 12/13 and up as it may cause
    // an issue that is not possible to test programmatically.
    // See: https://github.com/vaadin/vaadin-radio-button/issues/140
    if(isIOS){
      this.click();
    }
  }
});

[web-padawan]

In Vaadin 22 we refactored related code so this should not be a problem anymore. Vaadin 14 is still affected.