Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface.FieldEvents.FocusListener not working on some browsers #10414

Closed
JokerTheFourth opened this issue Dec 5, 2017 · 15 comments
Closed
Labels

Comments

@JokerTheFourth
Copy link

Vaadin versions: 8.1.7, 8.1.6, 8.1.5, 8.1.4
A call of FocusListener (interface.FieldEvnets.FocusListener) not working on some browsers like Microsoft Edge or Firefox but it works well with Google Chrome and Opera.

Example:
textField.addFocusListener(new FocusListener() { @Override public void focus(FocusEvent event) { Notification.show("It works!"); } });

@wbadam
Copy link
Contributor

wbadam commented Dec 29, 2017

Hi, I couldn't reproduce the issue using 8.1.4 on FF 56, IE11 or Edge with the given simple app that only contains the text field. All browsers seems to show the notification when the text field is focused.
Do you have some additional setup that could interfere with the event handling? Did you try the feature just with a very simple app?

@JokerTheFourth
Copy link
Author

JokerTheFourth commented Jan 4, 2018 via email

@draganr
Copy link

draganr commented Apr 13, 2018

I have the same problem with BlurListener in TextField inside complex project structure with Firefox Browser. Issue is: #10805

@TatuLund
Copy link
Contributor

I tested Focus and Blur listeners on Windows 10 / Edge (41.16299.371.0), Vaadin 8.3.1 and they both triggered correctly. There is number of reports of this issue, which indicates that something has gone wrong somewhere, but so far we have been unable to reproduce the issue.

@mcollovati
Copy link
Contributor

I don't know why but in the attached project (focus_example_2) the problem seems related to vaadin-board-precompiled dependency and more specifically to the webcomponents-lite.js script.

If you remove from pom the dependency to vaadin-board-precompiled the focus listener works.

It work also with vaadin-board-precompiled if you prevent webcomponents-lite.js to be loaded (eg with a Filter that intercepts the call and returns an empty response)

@TatuLund
Copy link
Contributor

@mcollovati Excellent observation!

webcomponents-lite.js is the polyfill library used with Board, since it is a webcomponent (we use webcomponents polyfill also in Flow). It quick glance I did not find generic issue reported in their issue tracker

https://github.com/webcomponents/webcomponentsjs/issues

If this turns out to be bug in polyfills library (i.e. it is somehow blocking the event), the issue should be filed there.

Similar issue has not been reported with Flow either yet.

@Artur-
Copy link
Member

Artur- commented Apr 15, 2018

Board precompiled probably contains a quite old version of the polyfill. Would make sense to upgrade to the latest to see if it resolves the issue

@stale
Copy link

stale bot commented Sep 12, 2018

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Sep 12, 2018
@draganr
Copy link

draganr commented Sep 13, 2018

I have checked with Vaadin 8.6.0.alpha1 ana Firefox 62.0 and the bug is still active as long as I have a Board add on within my project.

@stale stale bot removed the Stale Stale bot label label Sep 13, 2018
@devdev-dev
Copy link

devdev-dev commented Oct 1, 2018

We too have the problem with ignored focus and blur events. We do not have a problem with the newest Firefox but with Edge and the Internet Explorer. We tried the deprecated Vaadin 7 and Vaadin 8 TextField component. For both versions, we are not receiving any focus or blur event. The Value/Text Change Event ist working though.

We tested the following browsers/versions:

  • Works Firefox 63
  • Does not work Edge 42.17134.1.0
  • Does not work IE 11.285.17134.0

@draganr
Copy link

draganr commented Oct 1, 2018

@devdev-dev Do you use Vaadin Board add on in your project?

@devdev-dev
Copy link

@devdev-dev Do you use Vaadin Board add on in your project?

Nope - We are not using the Vaadin Board Add On.

@stale
Copy link

stale bot commented Feb 28, 2019

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Feb 28, 2019
@devdev-dev
Copy link

Unfortunately, the problem is still relevant and does not allow the use of Edge Browsers.
Is there any known fix or an updated version without that problem?

Works Chrome 77.0.3865.93
Works Firefox 69.0.1
Does not work Microsoft Edge 44.18362.329.0

We are using Vaadin 8.7.0

@stale stale bot removed the Stale Stale bot label label Sep 30, 2019
@TatuLund
Copy link
Contributor

I think this should have been fixed by vaadin/board#144

@TatuLund TatuLund added the bug label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants