Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker 22.0 : There's is still missing a handleUnparsableDateString as it was present in Vaadin 8 #2454

Closed
SonReimer opened this issue Dec 21, 2021 · 1 comment
Labels
enhancement New feature or request vaadin-date-picker

Comments

@SonReimer
Copy link

SonReimer commented Dec 21, 2021

After implementing methods setDateFormat(s), getDateFormat() in class DatePickerI18n (#911) there's still missing a method to handle a client unparsable input string on the serve as it was in Vaadin 8 DateField::handleUnparsableDateString(...)

In Java a DatePicker-Instance does not show any error after leaving it's field with an unparsable string as does with JavaScript.
As there's no possibility to handle the unparsable string on the server side, the user can not distinguish between an empty value and an unparsable string.
if the field is not requried, it looks like as if the unparsable string was accepted.

Following the demo for DatePicker V22, the component gets red for an unparsable string on TypeScript, but the component does not show up for java, so i could not test it there, but only in my code.

@rolfsmeds rolfsmeds added enhancement New feature or request vaadin-date-picker labels Dec 28, 2021
@rolfsmeds rolfsmeds changed the title DatePicker 22.0 : There's is still missing a handleUnparsableDateString as it was present in Vaadin 8 Server-side fallback parsing mechanism Dec 28, 2021
@rolfsmeds rolfsmeds changed the title Server-side fallback parsing mechanism DatePicker 22.0 : There's is still missing a handleUnparsableDateString as it was present in Vaadin 8 Dec 28, 2021
@rolfsmeds
Copy link
Contributor

Closing as duplicate of #2176 (missing validation) and #2466 (server-side fallback parsing mechanism)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaadin-date-picker
Projects
None yet
Development

No branches or pull requests

2 participants