From ec15ab146bcac10d2eb1fff9b56379e3595a9c99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Plewa?= Date: Fri, 23 Aug 2024 17:28:54 +0200 Subject: [PATCH] Fix coverity issue in BitMaskMax It should never happen but coverity do not know it. Assert should enough here --- src/tbbmalloc/tbbmalloc_internal.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/tbbmalloc/tbbmalloc_internal.h b/src/tbbmalloc/tbbmalloc_internal.h index 44fa47aaab..cac803de1c 100644 --- a/src/tbbmalloc/tbbmalloc_internal.h +++ b/src/tbbmalloc/tbbmalloc_internal.h @@ -232,9 +232,13 @@ template class BitMaskMax : public BitMaskBasic { public: void set(size_t idx, bool val) { + MALLOC_ASSERT(NUM >= idx + 1, ASSERT_TEXT); + BitMaskBasic::set(NUM - 1 - idx, val); } int getMaxTrue(unsigned startIdx) const { + MALLOC_ASSERT(NUM >= startIdx + 1, ASSERT_TEXT); + int p = BitMaskBasic::getMinTrue(NUM-startIdx-1); return -1==p? -1 : (int)NUM - 1 - p; }