Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

us-overlay--open doesn't do enough to prevent document scrolling. #267

Open
greenie opened this issue Oct 24, 2017 · 1 comment
Open

us-overlay--open doesn't do enough to prevent document scrolling. #267

greenie opened this issue Oct 24, 2017 · 1 comment
Assignees

Comments

@greenie
Copy link
Contributor

greenie commented Oct 24, 2017

When using -webkit-overflow-scrolling: touch; inside an open overlay, when you reach the top/bottom of the overlay, the body will continue to scroll.

If we change the implementation in overlay.js to add the class to html instead and update the Sass to:

.us-overlay--active {
  &,
  & body {
    width: 100%;
    height: 100%;
    overflow: hidden;
  }
}

This will fix overlays and allow people to use elastic scrolling within overlays.

@greenie greenie self-assigned this Oct 24, 2017
@annez
Copy link
Contributor

annez commented Jan 8, 2018

@greenie is this something we want to look at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants