Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Allow MaxConnectionAge on Server #433

Closed
pingles opened this issue Oct 22, 2020 · 1 comment · Fixed by #440
Closed

Allow MaxConnectionAge on Server #433

pingles opened this issue Oct 22, 2020 · 1 comment · Fixed by #440
Milestone

Comments

@pingles
Copy link
Contributor

pingles commented Oct 22, 2020

gRPC issues highlighted in #425 mention a preference to controlling flow of updates of the connection addresses via MAX_CONNECTION_AGE.

This should be added as a flag to the server, and passed when creating the gRPC server:

grpc.NewServer(grpc.KeepaliveParams(keepalive.ServerParameters{MaxConnectionAge: maxConnAge}))

The default value is infinity (https://github.com/grpc/grpc-go/blob/master/keepalive/keepalive.go#L60) but could be overridden to force clients to re-resolve and reconnect more regularly.

Should help #425 along with updating the gRPC Go version.

@pingles pingles added the bug label Oct 22, 2020
@pingles pingles added this to the v4 milestone Oct 22, 2020
@pingles pingles added enhancement and removed bug labels Oct 23, 2020
@stefansedich
Copy link
Contributor

@pingles do we want to keep the existing default of infinity or should we default to something more sensible that suits our needs better?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants